Skip to content

Make the demo compile with NDK#487

Open
floppyhammer wants to merge 1 commit into
servo:mainfrom
floppyhammer:fix_android_demo
Open

Make the demo compile with NDK#487
floppyhammer wants to merge 1 commit into
servo:mainfrom
floppyhammer:fix_android_demo

Conversation

@floppyhammer

Copy link
Copy Markdown
Contributor

Solving #472. Upgrade usvg to 0.20.0, which removes harfbuzz_rs dependency.

@floppyhammer

Copy link
Copy Markdown
Contributor Author

The demo shows some artifacts on Android, which doesn't occur in the last release. I'll open another PR to handle that.

@jdm

jdm commented Mar 27, 2022

Copy link
Copy Markdown
Member

@bors-servo r+
Thanks!

@bors-servo

Copy link
Copy Markdown
Contributor

📌 Commit 9c1f48a has been approved by jdm

bors-servo added a commit that referenced this pull request Mar 28, 2022
Make the demo compile with NDK

Solving #472. Upgrade `usvg` to `0.20.0`, which removes `harfbuzz_rs` dependency.
@bors-servo

Copy link
Copy Markdown
Contributor

⌛ Testing commit 9c1f48a with merge db0dfee...

@bors-servo

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-github

@jdm

jdm commented Mar 28, 2022

Copy link
Copy Markdown
Member
error[E0599]: no function or associated item named `from_file` found for struct `Tree` in the current scope
  --> utils/svg-to-skia/src/main.rs:16:22
   |
16 |     let tree = Tree::from_file(&input_path, &Options::default()).unwrap();
   |                      ^^^^^^^^^ function or associated item not found in `Tree`

@floppyhammer

Copy link
Copy Markdown
Contributor Author

@jdm Should probably merge #493 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants