Conversation
… unmapped keys deactivation
fd74e8f to
0004d93
Compare
Related Issues & Features SolvedFor context and review, this PR directly resolves several long-standing community feature requests and issues regarding keyboard-to-gamepad emulation:
|
There was a problem hiding this comment.
I think the editor looks really cool, but I'm reluctant to merge this, because a simpler first solution would be to add a new macro function, as mentioned in my comment #875 (comment)
This pr is also missing tests, and writing tests for an isolated small macro function will be much, much easier.
Once that macro function exists, there could be a menu to load one of a selection of default-presets (like one that maps wasd to the joystick, q and e to shoulder buttons, etc.), which can the be more easily adjusted by users without building a preset from scratch. This would also be easier on the codebase, I think. Loading some defaults into the preset json would be rather easy to test and implement.
If alternative editor layouts are a thing, I'd not do it as a separate tab, but rather some option inside of the editor tab. Maybe something below the autoload toggle, an "Editor" dropdown that lets one switch between "Classic", "XBox Gamepad" and potentially others.
I'd really like a qt rewrite of the gui instead of large new features to the existing gui though. And first go with some lower hanging fruit fixes to the linked issues.
| 103: "🡹 ARRIBA", | ||
| 105: "🡸 IZQUIERDA", | ||
| 106: "🡺 DERECHA", | ||
| 108: "🡻 ABAJO", |
There was a problem hiding this comment.
English in the code please. Translations via translation files
| local_path = os.path.abspath("data/xbox_controller.svg") | ||
| if os.path.exists(local_path): | ||
| return local_path | ||
| ws_path = "/home/vic/PROYECTOS/keyboard_as_xbox/input-remapper/data/xbox_controller.svg" |
There was a problem hiding this comment.
hardcoded path will break on other peoples instalations
There was a problem hiding this comment.
What's the source of this svg? There is https://vectorified.com/download-image#xbox-360-controller-vector-8.png, wihch has a CC license.
| @@ -1,5 +1,5 @@ | |||
| Package: input-remapper | |||
| Version: 2.2.1 | |||
| Version: 2.2.2 | |||
|
Started working on macros: #1370 |

Summary