Export empty CSV columns for reference command parameters - #902
Open
lixitrixi wants to merge 1 commit into
Open
Conversation
lixitrixi
force-pushed
the
fix-params-csv-export
branch
from
June 19, 2026 23:10
9af90fb to
4eb11e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #852
The problem was that the first command result was used to create the parameter CSV headers, even though this could be the reference command (which has no params). Here I find the first result with non-empty params and use it instead.
For the reference command, I export an empty value for each parameter to match the number of columns. IMO this is correct since the reference command has no parameter values. #877 uses lookup to print each column; I avoid this since iterating is cheaper and a reference command is very rare compared to parametrized commands.