Skip to content

Update .editorconfig#2

Open
shawnawsu wants to merge 1 commit into
masterfrom
shawnawsu-patch-1
Open

Update .editorconfig#2
shawnawsu wants to merge 1 commit into
masterfrom
shawnawsu-patch-1

Conversation

@shawnawsu

Copy link
Copy Markdown
Owner

No description provided.

@upsun-dispatch-dev upsun-dispatch-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Dispatch Review — full · 1 file reviewed · effort 🟢 XS

Summary

This PR modifies the repository's .editorconfig configuration file, changing the global trim_trailing_whitespace setting from true to false. It is a single-line change with no accompanying rationale or targeted scope.

Changes

Layer / File(s) Summary
Editor configuration
.editorconfig Flips the global trim_trailing_whitespace rule from true to false, disabling automatic trailing-whitespace removal for all file types in editors that honour .editorconfig.

Review Status

Analyzed · requesting changes · 🟡 1 warning

Reviewed by Upsun Dispatch · 2026-06-18 17:05 UTC

Comment thread .editorconfig
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
trim_trailing_whitespace = false

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Warning — Global disablement of whitespace trimming silently degrades diff readability and code hygiene across the entire repository with no scoped justification.

Changing trim_trailing_whitespace from true to false disables trailing-whitespace removal globally for every file type in the repository. Editors that respect .editorconfig will silently accumulate whitespace-only lines over time, polluting future diffs with noise and making git blame/git bisect harder to use. If the intent is to preserve trailing spaces only for a specific type (e.g. Markdown, where two trailing spaces encode a hard line-break), the correct fix is a targeted override section rather than a global change:

[*.md]
trim_trailing_whitespace = false

The global setting should remain true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant