Skip to content

Refactor(webapp) : Refactor webapp to use the shinzohub package #266

Merged
NiranjanaBinoy merged 8 commits into
mainfrom
ref/registered-data-fetch
Jul 2, 2026
Merged

Refactor(webapp) : Refactor webapp to use the shinzohub package #266
NiranjanaBinoy merged 8 commits into
mainfrom
ref/registered-data-fetch

Conversation

@NiranjanaBinoy

@NiranjanaBinoy NiranjanaBinoy commented Jun 28, 2026 •
edited by VanishMax
Loading

Copy link
Copy Markdown
Contributor

Pull Request

Description

Changes

  • Updated use-registered-generator and use-registered-host hooks to use /shinzohub/generators and /shinzohub/host for the registered data fetching
  • added new hooks for generator and host health check and health polling
  • Added new compoennt for the assertion verification in shinzohub package and related api and changes in teh use-verify-assertion hook.
  • Updated the registered data to use offset pagination and removed the cursor pagination.

Related Issue

Closes #251

Closes #225

Steps to Test

  1. Load https://ref-registered-data-fetch-shinzo-webapp-staging.shinzo-492.workers.dev/indexer-registration
  2. Observe the home page, make sure the host and indexer data is loading right and the pagination is working
  3. Swicth to indexer registration and make sure the assertion check is working, currently if you load the indexer registration page a banner will appear on top if the assertion is not done for the address. This flow will change in Two step Indexer Registration Process #256

Checklist

  • Code compiles / runs
  • Tests added / updated
  • Documentation updated if needed
  • PR is self-contained and focused
  • Code does not break any existing features
  • Code passes personal internal testing

Notes

@NiranjanaBinoy NiranjanaBinoy self-assigned this Jun 28, 2026
@NiranjanaBinoy NiranjanaBinoy added feature A new feature to be built or implemented enhancement New feature or request and removed feature A new feature to be built or implemented labels Jun 28, 2026
@NiranjanaBinoy NiranjanaBinoy linked an issue Jun 28, 2026 that may be closed by this pull request
Refactor the Indexer and host data fetch to use shinzohub package. #251
Closed
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 shinzo-webapp-staging f29df6c Commit Preview URL

Branch Preview URL		 Jul 02 2026, 02:19 PM

@NiranjanaBinoy NiranjanaBinoy force-pushed the ref/registered-data-fetch branch from 53a927b to c88795a Compare June 29, 2026 04:03
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 shinzo-explorer b8804e7 Commit Preview URL

Branch Preview URL		 Jul 02 2026, 05:44 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs		 shinzo-studio b8804e7 Commit Preview URL

Branch Preview URL		 Jul 02 2026, 05:44 AM

@NiranjanaBinoy NiranjanaBinoy marked this pull request as ready for review June 29, 2026 18:38
@NiranjanaBinoy NiranjanaBinoy requested a review from VanishMax June 29, 2026 19:42
@VanishMax VanishMax linked an issue Jun 30, 2026 that may be closed by this pull request
shinzohub client: apply library to the registration app #225
Closed
VanishMax
VanishMax approved these changes Jun 30, 2026
View reviewed changes

@VanishMax VanishMax left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Only added some small clean up notes

Comment thread apps/webapp/src/app/api/shinzohub/hosts/_lib/serialize.ts

@VanishMax VanishMax Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: reuse functions from different serialize.ts files – they seem to be doing the same stuff but with different names.

Comment thread packages/shinzohub/src/generators/get-generator-assertion.ts

@VanishMax VanishMax Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore: assertion can only be done by generators, so let's move this file into the generators shinzohub module

@NiranjanaBinoy NiranjanaBinoy force-pushed the ref/registered-data-fetch branch 2 times, most recently from 08f94a4 to 48ff51f Compare June 30, 2026 20:45
@NiranjanaBinoy NiranjanaBinoy force-pushed the ref/registered-data-fetch branch from 48ff51f to b8804e7 Compare July 2, 2026 05:42
@NiranjanaBinoy NiranjanaBinoy requested a review from VanishMax July 2, 2026 05:44
VanishMax
VanishMax approved these changes Jul 2, 2026
View reviewed changes

@VanishMax VanishMax left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the code, it looks good to me! Might need another review with tests by someone else do go around the app more deeply

@NiranjanaBinoy NiranjanaBinoy merged commit bffb55d into main Jul 2, 2026
2 checks passed
@NiranjanaBinoy NiranjanaBinoy deleted the ref/registered-data-fetch branch July 2, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VanishMax VanishMax VanishMax approved these changes

Assignees

@NiranjanaBinoy NiranjanaBinoy

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor the Indexer and host data fetch to use shinzohub package. shinzohub client: apply library to the registration app

2 participants

@NiranjanaBinoy @VanishMax