chore(deps): lucide-react 1.x (major) - #80
Merged
Merged
Conversation
lucide-react 1.0 removed all brand icons. This repo used seven of them
(Facebook, Linkedin, Twitter, Youtube, Github, Instagram, Dribbble) in
src/components/ui/share.tsx and src/components/ui/social-links.tsx. Those now
come from @tabler/icons-react (already a dependency, IconBrand* set); Twitter
maps to IconBrandX. The platformIcon record is typed as
ComponentType<{ className?: string }> so both icon libraries fit.
Other 1.0 changes (aria-hidden default, absoluteStrokeWidth deprecated for
nonScalingStroke, IconNode renamed LucideIconNode, UMD build dropped) do not
affect this code. All 35 other named imports across src/ still exist in 1.46.0.
Claude-Session: https://claude.ai/code/session_01KLWmWU1KLE2diUH14ryqv1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Resolves the package.json conflict by keeping main's jotai 3.0.0 and motion ^13.3.0 alongside this branch's lucide-react 1.46.0. The lockfile was regenerated from main's rather than hand-merged: the branch lockfile predated several major bumps on main (framer-motion 13, jotai 3, motion 13, vitest 5, uuid 14). Regenerated delta against main is the four lucide-react lines plus a transitive picomatch 4.0.5 to 4.0.7 re-resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence
Major bump of
lucide-reactfrom 0.564 to 1.46 with the two files that used its removed brand icons switched to@tabler/icons-react(left open for review because it is a major with source changes).Bumps
Breaking changes (1.0)
Source: https://github.com/lucide-icons/lucide/releases/tag/1.0.1 and the React migration guide in
docs/guide/react/migration.md.src/components/ui/share.tsx: Twitter, Facebook, Linkedinsrc/components/ui/social-links.tsx: Github, Twitter, Linkedin, Instagram, Facebook, Youtube, DribbbleBoth now import the matching
IconBrand*components from@tabler/icons-react, which is already a dependency (Twitter and X both map toIconBrandX). TheplatformIconrecord is typedComponentType<{ className?: string }>so lucide and tabler icons coexist. Neither file is rendered by a route today; both aretsc-excluded (src/components/ui/**), so I type-checked them in isolation and the only error left is a pre-existing one (siteConfig.socialdoes not exist onSiteConfig).aria-hidden="true"by default;absoluteStrokeWidthis deprecated fornonScalingStroke;IconNodeis deprecated forLucideIconNode; UMD build dropped. None of these are used here.LucideIcon/LucidePropstypes remain.lucide-reactacrosssrc/(35 names): all exist in 1.46.0.Supersedes dependabot #50 (which targeted 1.33.0 without the source fix).
Verification
pnpm typecheckcleanpnpm test: 4 files, 16 tests greenpnpm exec vitest run --config vitest.config.node.ts: 3 files, 21 tests greenpnpm buildpassesnext startsmoke:/200,/changelog200,/changelog/nope-xyz404,/faq200,/nope-404404Installed with
--ignore-scripts(isolated-vm postinstall fails under Node 26 locally; matches how Vercel builds).https://claude.ai/code/session_01KLWmWU1KLE2diUH14ryqv1