docs: do not use job duration to spot a billing-blocked Action - #90
Merged
Merged
Conversation
The note added in #89 said billing-blocked jobs fail in under about ten seconds. That is not dependable. A shipkit-www "Lint (biome + eslint + prettier)" job reported 38s and looked exactly like a real lint failure, but its annotation was the payments message and the job had never run. Reading the check-run annotation is the only reliable test, so say that and drop the duration heuristic. [skip ci]
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to #89, which I disproved within the hour.
That note said billing-blocked jobs fail in under about ten seconds. Not dependable: a shipkit-www
Lint (biome + eslint + prettier)job reported 38s and looked exactly like a real lint failure. Its annotation was the payments message and the job had never run.Reading the check-run annotation is the only reliable test:
So the doc now says that and drops the duration heuristic entirely. Docs only.