Skip to content

SFSEC-331: Use composite action for checkout. - #138

Merged
d3vpasha merged 3 commits into
masterfrom
sfsec-331-use-composite-action
Sep 11, 2026
Merged

d3vpasha merged 3 commits into
masterfrom
sfsec-331-use-composite-action

Conversation

@shoppingfeed-titusm

@shoppingfeed-titusm shoppingfeed-titusm commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Link to the issue

https://shopping-feed.atlassian.net/browse/SFSEC-331

Reason for this PR

Aikido scan

What does the PR do

  • update to shoppingflux/github-actions/checkout@main
  • checked that fetch-depth param already exists;

How to test

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The workflow YAML indentation makes the steps block invalid and the action reference should be pinned to an immutable ref rather than @main.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the CI workflow to use the organization’s composite checkout action instead of the upstream actions/checkout, aligning the pipeline with internal security/scanning requirements.

Changes:

  • Switches the PHP workflow’s checkout step to shoppingflux/github-actions/checkout@main.
File summaries
File Description
.github/workflows/php.yml Replaces the checkout action used in the PHP CI workflow.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/php.yml
Comment thread .github/workflows/php.yml Outdated
d3vpasha
d3vpasha previously approved these changes Sep 10, 2026
@d3vpasha

Copy link
Copy Markdown
Contributor

@shoppingflux/squad-core we've also applied the PHP version changes to this public repo.

@d3vpasha
d3vpasha self-requested a review September 11, 2026 14:32
@d3vpasha
d3vpasha merged commit 6991845 into master Sep 11, 2026
3 checks passed
@d3vpasha
d3vpasha deleted the sfsec-331-use-composite-action branch September 11, 2026 14:32
@Aurelieluciani

Copy link
Copy Markdown
Contributor

@d3vpasha For a public library, we can't change the minimum PHP version like this. Please don't create a new release with this PR, as we could break the code of users who depend on our library.

@d3vpasha

Copy link
Copy Markdown
Contributor

@shoppingfeed-titusm could you please revert this change asap ?

@shoppingfeed-titusm

Copy link
Copy Markdown
Contributor Author

yes, on it

@shoppingfeed-titusm

shoppingfeed-titusm commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor Author

@Aurelieluciani @d3vpasha I've created #139 I hope that's ok.
The pipeline will still fail. Do you want me to look for alternate solutions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants