docs(hosting): add ext-xmlreader to required PHP extensions#2307
Open
Martin Krzykawski (MartinKrzykawski) wants to merge 1 commit into
Open
docs(hosting): add ext-xmlreader to required PHP extensions#2307Martin Krzykawski (MartinKrzykawski) wants to merge 1 commit into
Martin Krzykawski (MartinKrzykawski) wants to merge 1 commit into
Conversation
The Shopware core relies on \XMLReader (used by SvgContentValidator). ext-xmlreader is a core PHP extension but has its own configure flag, so minimal PHP builds can omit it. Listing it explicitly in the hosting requirements keeps the docs aligned with the composer manifests. Relates shopware/shopware#16961 Relates shopware/shopware#17020
Copilot started reviewing on behalf of
Martin Krzykawski (MartinKrzykawski)
May 26, 2026 12:56
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the hosting requirements documentation to reflect that Shopware also requires the PHP xmlreader extension (used by core SVG validation via \XMLReader), keeping the public docs aligned with the platform dependency declaration.
Changes:
- Add
xmlreaderto the “Required extensions” list on the hosting requirements page. - Keep the extensions list alphabetically ordered (
xml,xmlreader,zip).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Marcel Brode (marcelbrode)
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
xmlreaderto the list of required PHP extensions on the hosting requirements page (guides/hosting/index.md).The Shopware core uses
\XMLReaderinSvgContentValidator(validates uploaded SVGs).ext-xmlreaderis a core PHP extension but has its own--enable-xmlreaderconfigure flag separate fromext-xml, so minimal/custom PHP builds can ship without it. The platform-side fix declares the dependency in the composer manifest; this PR keeps the public hosting docs in sync.Related links
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted..wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Notes
Single-line edit; the extension is inserted alphabetically between
xmlandzipin the existing comma-separated list.