fix(templates): avoid type cast and add no-cms fallback in FrontendLandingPage#2464
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the FrontendLandingPage component in both the vue-demo-store and vue-starter-template templates to remove a direct as Ref<Schemas["LandingPage"]> type cast by introducing a computed ref with explicit error throwing, and adds a template fallback when cmsPage is missing.
Changes:
- Replace the
as Ref<Schemas["LandingPage"]>cast with acomputed()accessor that throws if data is missing. - Add a
v-elseUI fallback for cases wherecmsPageis not present. - Simplify breadcrumbs setup by relying on the early “no landingResponse” throw.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| templates/vue-starter-template/app/components/FrontendLandingPage.vue | Removes type cast via computed narrowing; adds cmsPage missing fallback UI. |
| templates/vue-demo-store/app/components/FrontendLandingPage.vue | Mirrors the same landing page typing + cmsPage fallback changes in demo store template. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
21
| if (!landingResponse.value) { | ||
| console.error("[FrontendLandingPage.vue]", error.value?.message); | ||
| throw createError({ | ||
| statusCode: 500, | ||
| message: error.value?.message, | ||
| }); |
Comment on lines
+26
to
+34
| const landingPage = computed(() => { | ||
| if (!landingResponse.value) { | ||
| throw createError({ | ||
| statusCode: 500, | ||
| message: error.value?.message, | ||
| }); | ||
| } | ||
| return landingResponse.value; | ||
| }); |
Comment on lines
+16
to
21
| if (!landingResponse.value) { | ||
| console.error("[FrontendLandingPage.vue]", error.value?.message); | ||
| throw createError({ | ||
| statusCode: 500, | ||
| message: error.value?.message, | ||
| }); |
Comment on lines
+26
to
+34
| const landingPage = computed(() => { | ||
| if (!landingResponse.value) { | ||
| throw createError({ | ||
| statusCode: 500, | ||
| message: error.value?.message, | ||
| }); | ||
| } | ||
| return landingResponse.value; | ||
| }); |
Patryk Tomczyk (patzick)
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #1846
Summary
as Ref<Schemas["LandingPage"]>cast with acomputed()that narrows the type via an explicit throw - addresses #1843 review commentv-elsefallback in the template whencmsPageis missing - addresses #1843 review commentif (landingResponse.value)guard around breadcrumbs (the early throw already handles the null case)vue-demo-storeandvue-starter-template