SG-44731 Adopt Git LFS for tk-core vendored dependency ZIPs - #1128
Draft
julien-lang wants to merge 5 commits into
Draft
SG-44731 Adopt Git LFS for tk-core vendored dependency ZIPs#1128julien-lang wants to merge 5 commits into
julien-lang wants to merge 5 commits into
Conversation
- .tkdeploy: replace obsolete CI file exclusions (.travis.yml, appveyor.yml) with the files actually used today (.pre-commit-config.yaml, azure-pipelines.yml, build_resources.yml, codecov.yml, developer/) - azure-pipelines.yml: restrict branch trigger to master (was "*"), and temporarily pin the tk-ci-tools template ref to ticket/SG-44731-use-git-lfs for end-to-end testing before that PR merges - .gitattributes: minor formatting (blank lines, comment header for the LFS rule)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1128 +/- ##
==========================================
+ Coverage 80.11% 80.12% +0.01%
==========================================
Files 203 203
Lines 19540 19553 +13
==========================================
+ Hits 15654 15667 +13
Misses 3886 3886
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| qInitResources() | ||
| version https://git-lfs.github.com/spec/v1 | ||
| oid sha256:8376f448174f66831ffd5b1ee0a8c2a9275a3d98dfad3e4a24289069d2ddc107 |
|
|
||
|
|
||
| qInitResources() | ||
| version https://git-lfs.github.com/spec/v1 |
There was a problem hiding this comment.
missing whitespace after ':'
missing whitespace around arithmetic operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Adopts Git LFS for vendored dependency ZIPs to reduce Toolkit repo/clone size, starting with
tk-core'srequirements/**/*.zipfiles.Changes
requirements/**/*.zip(pkgs.zipfor all supported Python versions,flow_data_sdk-beta.zip) are now tracked via Git LFS (filter=lfs diff=lfs merge=lfs -textin.gitattributes)..tkdeploy: refreshed the packaging exclusion list, replacing obsolete CI file names (.travis.yml,appveyor.yml) with the ones actually used today (.pre-commit-config.yaml,azure-pipelines.yml,build_resources.yml,codecov.yml,developer/).azure-pipelines.yml: restricted the branch trigger tomaster(was*).Note before merging
azure-pipelines.ymlcurrently pins thetk-ci-toolstemplate ref torefs/heads/ticket/SG-44731-use-git-lfs(markedTEMPin the file) so this branch can be end-to-end tested against tk-ci-tools#77 before that PR merges. This must be reverted tomasteronce tk-ci-tools#77 is merged, or CI on this branch will keep depending on an unmerged branch.Testing