Add console warnings when WebGL is unavailable#107
Open
himself65 wants to merge 1 commit intoshuding:mainfrom
Open
Add console warnings when WebGL is unavailable#107himself65 wants to merge 1 commit intoshuding:mainfrom
himself65 wants to merge 1 commit intoshuding:mainfrom
Conversation
Previously, COBE silently returned no-op objects when WebGL was unavailable or shaders failed to compile, making it hard to debug. This adds console.warn messages for three failure scenarios: - WebGL not supported by browser/device - Shader program compilation failure - Runtime WebGL context loss/restoration
|
@himself65 is attempting to deploy a commit to the shu Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.warnwhen neither WebGL2 nor WebGL1 context can be obtained (unsupported browser/device)console.warnwhen shader programs fail to compilewebglcontextlost/webglcontextrestoredevent listeners to warn on runtime context lossdestroy()Previously, all WebGL failures silently returned no-op objects, making it difficult for developers to understand why the globe wasn't rendering.
Test plan
WEBGL_lose_contextextension)destroy()is called