test: cover parse case edge cases - #50
Merged
Merged
Conversation
Owner
|
ACK Coverage looks right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The case parser was only exercised through successful command-line parses of the two example vectors. Parser rejection behavior, explicit input formats, and v2 serialization stability did not have focused regression coverage.
Root Cause
make check-scriptsinvokedparse_case.pyfor valid fixtures but did not run assertions over malformed inputs or parser helper behavior.Change Summary
parse_case_smoke.pysuitemake check-scriptsand document itTesting
python3 scripts/parse_case_smoke.py— passedpython3 -m py_compile scripts/parse_case_smoke.py— passedmake check-claims check-comments PYTHON=python3— passedgit diff --check— passedmake check-scripts— new parser smoke passed; the existing C++ worker smoke could not compile locally becausesecp256k1.his not installedPrimary Sources
tests/vectors/scripts/parse_case.pyRelease Impact
Test-only change; no runtime or release behavior changes.
Checklist