fix: reject empty models during signing and verification - #662
Merged
mihaimaruseac merged 1 commit intoSep 4, 2026
Merged
Conversation
sampras343
marked this pull request as draft
September 4, 2026 10:28
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
sampras343
force-pushed
the
fix/reject-empty-model-signing
branch
from
September 4, 2026 10:29
f2813ee to
9dfd253
Compare
sampras343
marked this pull request as ready for review
September 4, 2026 10:32
Per OMS spec v1.0 §6.1, a model MUST contain at least one regular file after exclusions are applied, and §5.2.1 requires the resources array to contain at least one entry. Previously, signing an empty directory succeeded and produced a bundle with resources: [], which also passed verification. - Signing now rejects models with no regular files after exclusions - Shard serialization rejects models with only zero-byte files (which produce no shards per §6.3.2) - Verification rejects bundles with an empty resources array - Updated tests to validate rejection and use appropriate model lists Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
sampras343
force-pushed
the
fix/reject-empty-model-signing
branch
from
September 4, 2026 13:21
9dfd253 to
cea01ec
Compare
mihaimaruseac
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #661
Checklist