fix: reject expired and not-yet-valid certificates during signing and verification - #664
Open
sampras343 wants to merge 1 commit into
Open
fix: reject expired and not-yet-valid certificates during signing and verification#664sampras343 wants to merge 1 commit into
sampras343 wants to merge 1 commit into
Conversation
… verification The certificate-based signing flow accepted expired and not-yet-valid leaf certificates without any temporal validation. The verification flow pinned the X509 store time to the certificate's not_valid_before, causing the validity check to pass tautologically — even for certificates that expired years ago. Signing: - Added validity period check in Signer.__init__ that rejects leaf certificates whose not_valid_after is in the past or not_valid_before is in the future Verification: - Removed set_time(not_valid_before) call so pyOpenSSL evaluates the certificate chain against the current time, correctly rejecting expired or not-yet-valid certificates at any position in the chain Per OMS spec v1.0 §8.2: "The leaf certificate MUST be within its validity period." Signed-off-by: Sachin Sampras M <sampras343@gmail.com>
sampras343
force-pushed
the
fix/reject-expired-certificates
branch
from
September 4, 2026 14:28
0f4104c to
c1140f3
Compare
stefanberger
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #663
Checklist