Fix bugs in jackhammer - #516
Merged
Merged
Conversation
tristpinsm
commented
Aug 26, 2026
tristpinsm
commented
Contributor
- Parts of the script are run in docker containers. This allocates a TTY by default which messes with standard output afterwards. Disable this except for interactive sessions.
- Remove mutable defaults trap. fixes Mutable defaults in jackhammer functions #515
msilvafe
approved these changes
Aug 26, 2026
msilvafe
left a comment
msilvafe
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I love when the python documentation calls me a neophyte.
Contributor
Author
yeah I only learned about this from Brian a few months ago! That FAQ entry is pretty smug |
BrianJKoopman
left a comment
BrianJKoopman
left a comment
Member
There was a problem hiding this comment.
Looks good! Just one small suggestion, which you can change if you'd like, otherwise merge away.
tristpinsm
force-pushed
the
tpm/jackhammer-tty
branch
from
August 26, 2026 19:35
b473c4c to
f937a27
Compare
tristpinsm
force-pushed
the
tpm/jackhammer-tty
branch
from
August 26, 2026 19:54
f937a27 to
37caa8c
Compare
BrianJKoopman
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.