Update get_obslist file handling - #1716
Merged
Merged
Conversation
Contributor
|
I'm a bit confused by this PR...what exactly is this solving? In SAT-ISO we already routinely pass paths to a txt file with a list of obsids in it and it's handled just fine through the block: |
Contributor
Author
Mostly it was just to make it more obvious in the code that this function accepts a text file as input (wasn't in the docstring). I figured I'd just improve the handling of file inputs at the same time instead of just having it do a try except. There were no bugs in the implementation. |
msilvafe
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor change to make it more clear that
get_obslistaccepts either a file input or obsdb query. Came up when #1676 was being tested.