Support crosstalk sims with real observations - #1717
Merged
Merged
Conversation
tskisner
marked this pull request as ready for review
August 12, 2026 20:38
Member
Author
|
I will rebase this work after #1630 is merged. |
tskisner
force-pushed
the
tsk/sim_sso
branch
3 times, most recently
from
August 20, 2026 13:20
9b6443b to
974a967
Compare
tpsatt
reviewed
Aug 24, 2026
- Support real metadata names as seen in a typical observation. - If using real observations, do not require DetMap. - Refactor crosstalk utils to extract code that is common between the simulated and real observing cases. - In SimSSO operator, apply detector cuts if they exist. - When using real data, translate band names to expected format - Add det_mask trait and handle detectors which are flagged as invalid. - Update detector flags if saturated - Add support for per-detector elevation. Remove calculation of loading based on the TOD.
tskisner
force-pushed
the
tsk/sim_sso
branch
from
September 2, 2026 14:51
974a967 to
48f97bf
Compare
Member
Author
|
Ok, @tpsatt this is ready for re-review. I updated the unit test so that it is not run unless jbolo is found and the appropriate environment variables are set. For example, to run the unit test locally, ensure that |
Contributor
tpsatt
reviewed
Sep 11, 2026
tpsatt
reviewed
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Uh oh!
There was an error while loading. Please reload this page.