Skip to content

Support crosstalk sims with real observations - #1717

Merged
tskisner merged 4 commits into
masterfrom
tsk/sim_sso
Sep 11, 2026
Merged

tskisner merged 4 commits into
masterfrom
tsk/sim_sso

Conversation

@tskisner

@tskisner tskisner commented Aug 12, 2026 •

Copy link
Copy Markdown
Member
  • Support real metadata names as seen in a typical observation.
  • If using real observations, do not require DetMap.
  • Refactor crosstalk utils to extract code that is common between the simulated and real observing cases.
  • In SimSSO operator, apply detector cuts if they exist.
  • When using real data, translate band names to expected format
  • Add det_mask trait and handle detectors which are flagged as invalid.
  • Update detector flags if saturated
  • Add support for per-detector elevation. Remove calculation of loading based on the TOD.

@tskisner tskisner changed the title Work in progress on cleanup of SimSSO operator Support crosstalk sims with real observations Aug 12, 2026
@tskisner
tskisner marked this pull request as ready for review August 12, 2026 20:38
@tskisner
tskisner requested review from tpsatt and ttsan2521 August 12, 2026 20:39
@tskisner

Copy link
Copy Markdown
Member Author

I will rebase this work after #1630 is merged.

@tskisner
tskisner force-pushed the tsk/sim_sso branch 3 times, most recently from 9b6443b to 974a967 Compare August 20, 2026 13:20
Comment thread sotodlib/toast/ops/mumux_crosstalk_util.py
- Support real metadata names as seen in a typical observation.

- If using real observations, do not require DetMap.

- Refactor crosstalk utils to extract code that is common
  between the simulated and real observing cases.

- In SimSSO operator, apply detector cuts if they exist.

- When using real data, translate band names to expected format

- Add det_mask trait and handle detectors which are flagged
  as invalid.

- Update detector flags if saturated

- Add support for per-detector elevation.  Remove calculation
  of loading based on the TOD.
@tskisner

tskisner commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

Ok, @tpsatt this is ready for re-review. I updated the unit test so that it is not run unless jbolo is found and the appropriate environment variables are set. For example, to run the unit test locally, ensure that DetMap and JBolo are installed and then do something like:

JBOLO_PATH="/path/to/jbolo" \
JBOLO_MODELS_PATH="/path/to/bolocalc-so-model" \
OMP_NUM_THREADS=4 \
pytest -s sotodlib/tests/test_sim_mumux_crosstalk.py

@tpsatt

tpsatt commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Confirming that the unit tests work, and that this produces sensible CMB sims for the LAT D56 region
Screenshot 2026-09-11 at 3 55 56 PM

Comment thread sotodlib/toast/ops/sim_mumux_crosstalk.py Outdated
Comment thread sotodlib/toast/ops/sim_mumux_crosstalk.py Outdated

@tpsatt tpsatt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes

@tskisner
tskisner merged commit cce97f0 into master Sep 11, 2026
5 checks passed
@tskisner
tskisner deleted the tsk/sim_sso branch September 11, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants