Add bandpass specific preproc noise select - #1729
Merged
Merged
Conversation
msilvafe
requested changes
Sep 1, 2026
Comment on lines
+909
to
+910
| mask = (meta.det_cal.bandpass == k) | ||
| keep[mask] &= (wn[mask] <= v) |
Contributor
There was a problem hiding this comment.
Why use det_cal instead of det_info here? Also this requires a context with some non-zero metadata so I think we need to check for this and raise some suitably clear error. Maybe like if det_info in meta then use det_info bandpass, else if det_cal in meta then use det_cal, else raise a value error that neither det_cal nor det_info exist in meta
Contributor
Author
There was a problem hiding this comment.
Yeah was handling bandpass in an incomplete manner. It will now try to get det_info.wafer.bandpass first and det_cal.bandpass second. If it doesn't find either it just sets it to None since we may not need it. Trying to run the bandpass selects will then error out cleanly if it is None.
added 2 commits
September 1, 2026 12:44
msilvafe
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass in a dictionary for the
noiseprocess stageselectfunction parametersmin_noise,max_noise, andmax_fknee. This is to avoid the LAT preprocessing from needing different configs, since noise is currently the only process that needs different values. Maintains backwards compatibility and will throw TypeError if not afloat,int, ordict.