Extract library versions into vals in build.mill#87
Draft
kubukoz wants to merge 1 commit into
Draft
Conversation
Why: avoid duplicating version literals across modules and make bumps easier to spot/coordinate. Pre-existing version bumps (e.g. lsp-smithy-definitions 0.3.0, bsp4s 0.7.0, jsonrpc 0.2.0) are kept as-is and referenced by val. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.millup into a top-levelvaland reference it via interpolation.lsp-smithy-definitions:0.3.0,bsp4s:0.7.0,jsonrpcVersion 0.2.0, smithy4s plugin0.19.7) are kept verbatim — only the indirection changes.testModule's Scala version (3.7.4) is also lifted into a val for consistency.Build status
lsp-smithy-definitions:0.3.0resolves now (it was published during this session — initial failure was due to the artifact not yet being on Maven Central).sls/(DiagnosticManager, MessageTracer, ServerImpl) because the bumped upstream libraries changed their APIs (e.g.lsp.SignatureHelpis no longer wrapped inOption,List[lsp.Location]no longer acceptsNone, etc.).Test plan
./mill __.compile— blocked on a separate follow-up to adaptsls/sources to new lsp-smithy-definitions / jsonrpclib / bsp4s APIs./mill _.test— blocked on the above🤖 Generated with Claude Code