Feature/hover lab view - #217
Open
meganrm wants to merge 19 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…et is open Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously, passing includedPages caused shouldRender = false for any module not in the map, because undefined?.includes() ?? false evaluates to false. This silently hid the EventsOverTimePlot on all pages of Module.A_B_AB. Now only applies the includedPages constraint when the current module is actually a key in the map. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…into feature/hover-lab-view
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
meganrm
requested review from
ShrimpCryptid and
interim17
and removed request for
a team
August 11, 2026 23:02
meganrm
requested
a lite review from Copilot
and removed request for
ShrimpCryptid and
interim17
August 11, 2026 23:06
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (5)
src/components/ScaleBar.tsx:13
- Destructured keys must be alphabetical under the project guideline, so
classNameshould come beforeproductColor.
const ScaleBar: React.FC<ScaleBarProps> = ({ productColor, className }) => {
src/components/ViewSwitch.tsx:55
- On non-intro pages this branch removes all text from the toggle, while
LabIconhas no accessible SVG name (src/components/icons/Lab.tsx:5-11), so assistive technology encounters an unnamed button. Give the toggle a state-aware accessible name and expose its pressed state.
{/* on the first page we show text, but on other pages we just show the icon */}
{isFirstPageOfFirstModule
? `${isLabViewOpen ? "Simulation" : "Lab"} view`
: null}
src/components/shared/ButtonLibrary.tsx:97
activeis a styling-only wrapper prop, but{...props}also passes it through AntD to the native button. This produces an invalid boolean DOM attribute warning whenever this component receivesactive; omit the wrapper prop from the forwarded object.
{...props}
className={classNames(props.className, { [styles.active]: active })}
src/components/ScaleBar.tsx:2
- The project guideline requires external imports to be alphabetized;
classnamesshould precedereact.
This issue also appears on line 13 of the same file.
import React from "react";
import classNames from "classnames";
src/components/LabView.tsx:20
- Destructured context keys must be alphabetical under the project guideline; order these as
module,page, thensetViewportType.
const { page, module, setViewportType } = useSimulariumUi();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: small
the toggle between "Lab View" and "Molecular View" was too jarring (the whole screen changed and didn't allow for side by side comparison.
Solution
Have the "lab view" be just a small overlay that shows the cuvette instead of changing the whole panel.
Type of change
Please delete options that are not relevant.
Steps to Verify:
Screenshots (optional):
Design

Implementation