Fix trajectory fetch error handling and add loading/error UI - #219
Open
meganrm wants to merge 1 commit into
Open
Fix trajectory fetch error handling and add loading/error UI#219meganrm wants to merge 1 commit into
meganrm wants to merge 1 commit into
Conversation
…ding/error UI (UX1) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
meganrm
requested review from
interim17 and
tyler-foster
and removed request for
a team
August 11, 2026 23:54
meganrm
marked this pull request as draft
August 12, 2026 17:44
meganrm
marked this pull request as ready for review
August 12, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: medium
fetch3DTrajectory's catch block only didconsole.log(error)and never reported failure to the caller, soApp.tsxunconditionally settrajectoryStatustoLOADEDeven after a failed fetch. Separately, nothing in the app ever rendered UI based ontrajectoryStatusat all — a loading or failed fetch just left the viewer blank with no feedback.Fixes #223
Solution
fetch3DTrajectorynow returns a success boolean instead of swallowing errors.App.tsxsetsTrajectoryStatus.ERRORon failure instead of alwaysLOADED.trajectoryStatusis now exposed throughSimulariumSimulationContextsoViewer.tsxcan consume it, and shows a loading spinner while fetching and an error message + retry button on failure (retry resets status toINITIAL, re-entering the existing fetch effect).Type of change
Please delete options that are not relevant.
Change summary:
fetch3DTrajectoryreturns a success boolean instead of swallowing errorsApp.tsxsetsTrajectoryStatus.ERRORon failure instead of alwaysLOADEDtrajectoryStatus/setTrajectoryStatusexposed throughSimulariumSimulationContextViewer.tsxshows a loading spinner while fetching and an error message + retry button on failureSteps to Verify:
Screenshots (optional):
Keyfiles (delete if not relevant):
Thanks for contributing!