Stop resetting experiment data on window resize (shrink), warn on grow - #221
Draft
meganrm wants to merge 1 commit into
Draft
Stop resetting experiment data on window resize (shrink), warn on grow#221meganrm wants to merge 1 commit into
meganrm wants to merge 1 commit into
Conversation
…riggered reset (B2, B4) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
meganrm
requested review from
frasercl and
interim17
and removed request for
a team
August 12, 2026 17:43
meganrm
marked this pull request as draft
August 12, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: medium
clientSimulatorinApp.tsxwas auseMemodepending onviewportSize.width/height. Any window resize — even shrinking, even a single pixel — recreated the entireBindingSimulatorand, as side effects inside the memo body (a React anti-pattern), calledsetInputConcentration(...)andclearAllAnalysisState(), silently wiping any recorded equilibrium data.Fixes #224
Solution
Resize handling is now asymmetric and intentional:
antd Modal.warning()explains why, so students aren't surprised mid-experiment.setInputConcentration/clearAllAnalysisStatewere also moved out of theuseMemobody into a separateuseEffectkeyed on[currentModule, sectionType], so they only fire on real experiment changes, never as auseMemoside effect.Type of change
Please delete options that are not relevant.
Change summary:
setInputConcentration/clearAllAnalysisStateinto auseEffectkeyed on[currentModule, sectionType], out of theuseMemobodySteps to Verify:
Screenshots (optional):
Keyfiles (delete if not relevant):
Thanks for contributing!