Add KiDerivation modal for Competitive Binding module - #222
Draft
meganrm wants to merge 1 commit into
Draft
Conversation
…thing real (MF1) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
meganrm
requested review from
toloudis and
tyler-foster
and removed request for
a team
August 12, 2026 17:46
meganrm
marked this pull request as draft
August 12, 2026 17:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Estimated review size: medium
KiQuestion's failure message told students to "Visit the 'Learn how to derive Ki' button above," but no such button or modal existed anywhere in the Competitive Binding module — unlikeKdQuestion's equivalent message, which correctly points at a realKdDerivationmodal in the High Affinity module.Fixes #227
Solution
Built a
KiDerivationmodal (andKiDerivationContent) mirroringKdDerivation's existing pattern, and wired it onto the same content page as theKiQuestionquiz — the same placement patternKdDerivationuses. Content is adapted/condensed from the module's existing "Deriving Ki" page rather than written from scratch.KiQuestion.tsx's failure message text is unchanged — it was already correct copy, it just had nothing to point to.Type of change
Please delete options that are not relevant.
Change summary:
KiDerivation/KiDerivationContentcomponents mirroringKdDerivation/KdDerivationContentCompetitive.tsxSteps to Verify:
Screenshots (optional):
Keyfiles (delete if not relevant):
Thanks for contributing!