fix(lint): check the Agent Skills naming rule against the spec, not just Zed - #117
Merged
Conversation
…ust Zed KSF's name rule permits `tidy--commits` and `tidy-`. The Agent Skills spec — the shared authority every skills-directory target defers to — forbids a leading, trailing or consecutive hyphen outright, and requires the name to match its parent directory. So those names are legal KSF that Claude Code, Codex, Copilot, Cline, Zed, Gemini CLI and Agent Plugins may all refuse, and several refuse silently. Only the zed adapter flagged it, which scoped a spec-wide rule to one target and left the other six unmentioned. It is now reported once against the skill, at install, lint and test, citing the spec rather than a single client. A warning, not a failure: the name is valid KSF and still compiles, and --strict escalates it like any other warning. Verified against agentskills.io/specification, which states the rule verbatim: 1-64 characters, lowercase alphanumerics and hyphens, "Must not start or end with a hyphen", "Must not contain consecutive hyphens". Adds 5 tests. 0.24.1.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
KSF's own name rule permits
tidy--commitsandtidy-. The Agent Skills spec — the shared authority every skills-directory target defers to — forbids them outright:So those are legal KSF names that Claude Code, Codex, Copilot, Cline, Zed, Gemini CLI and Agent Plugins may all refuse — and several refuse silently.
Only the
zedadapter flagged it. That scoped a spec-wide rule to one target and left the other six unmentioned, so a user could reasonably read "→ zed" as "fine everywhere else."Now
Reported once against the skill, at
install,lintandtest, citing the spec rather than a single client:A warning, not a failure — the name is valid KSF and still compiles;
--strictescalates it like any other warning.Verified against the spec page directly rather than secondhand, after two secondhand reports disagreed about Zed's exact regex.
5 new tests. Typecheck, suite, bench and site
--checkverified by exit code. Ships as 0.24.1.