docs: SingleStore SQLGetTypeInfo fix merged upstream (#48) - #142
Merged
Merged
Conversation
Approved and merged 2026-09-23 by the maintainer, merge commit 182ae5b515, closing memsql/singlestore-odbc-connector#45 the same minute. The review asked for the test to run on its own connection, following the project's odbc143, and to restore sql_mode before disconnecting; both are in the second commit. The driver was rebuilt from the merged branch here and the whole info suite is green in both the client-side and the server-side prepared-statement modes. The compat note is now scoped to 1.2.2, which is still the current release, so the shipped-in line waits for the next tag. master is at 1.2.2 with no version bump staged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our fix PR memsql/singlestore-odbc-connector#48 was approved and merged this morning (2026-09-23T09:34:40Z, merge commit
182ae5b515), which closed #45 the same minute.SQLGetTypeInfobuilt its type table as aSELECTof double-quoted string literals, so any session withANSI_QUOTESinsql_moderead them as identifiers and the call failed with42S22 Unknown column 'json'. Single-quoted literals fix it.Two commits landed: the
ma_info.cchange, and a test change the review asked for — run on a connection of its own, following the project's ownodbc143, and restoresql_modebefore disconnecting.Verified here beyond their CI, which cannot run on a fork PR (the "Build & Test" legs need a management token secret a fork cannot read): the driver was rebuilt from the merged branch on this machine and the whole
infosuite passes, 44 of 44, in both the client-side and the server-side prepared-statement modes, against a server whosesql_modeis non-empty so the save-and-restore is exercised. Running the pre-review version of the test showed it had not been masking a later failure in that file, so the change is robustness rather than a hidden bug.Changes:
docs/UPSTREAM.md— the row moves to fixed, with the merge commit, what the review asked for, and the local verification. The status widget needs no change: the linked issue is closed as completed, which it already renders as fixed.tests/compat/README.md— theSQLGetTypeInfo/ANSI_QUOTESsection is now scoped to 1.2.2, the current release, and says where the fix landed. The comparison-table row carries the same.Not yet released.
masteris still at 1.2.2 with no version bump staged, and their own pattern is an explicit bump commit before a tag, so the "fixed in" line waits — most likely 1.2.3.#47, theSQLColumns/SQLPrimaryKeysNULL catalogue fix, is still open upstream.