docs: link omniload's actual release tag, and the install extra - #143
Open
singhpratech wants to merge 1 commit into
Open
singhpratech wants to merge 1 commit into
singhpratech wants to merge 1 commit into
Conversation
The README pointed at omniload's generic releases page. It now links v0.17.0, which is the release that first carried the adbcbridge backend: our merge commit is dated 2026-09-17T13:57:29Z and the v0.17.0 release commit 14:01:26Z, four minutes later, with the extra present in that tag's pyproject and absent from v0.16.0's. Adds the install line, since that is what a reader wants. PyPI's metadata for the published package declares the extra as adbcbridge>=0.1.3,<0.2, and omniload's own full and test extras pull it in.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README said the backend ships "since its 0.17 release" but linked omniload's generic releases page, so a reader could not get to the release itself or see how to install it.
Which release first carried it, checked rather than assumed. Our merge commit
cb49538cis dated 2026-09-17T13:57:29Z; thev0.17.0release commit is 14:01:26Z, four minutes later. Theadbcbridgeextra is inpyproject.tomlatv0.17.0and absent atv0.16.0. So v0.17.0 is the first release with it, and the existing claim was correct — only the link was vague.The install line is verified against PyPI, not just the repo: the published metadata declares
adbcbridge<0.2,>=0.1.3; extra == "adbcbridge", and omniload's ownfullandtestextras pull it in — their test extra means their CI installs adbcBridge.One deliberate omission:
v0.18.0is tagged on GitHub (2026-09-22) but PyPI's latest is still 0.17.0, so the text says "carried by every release since" rather than naming a version apip installwould not yet get.