fix(cli): uffs --status broker section is "not applicable" off Windows#468
Merged
Conversation
On macOS/Linux, `uffs --status` reported the Access Broker as "not installed" and advertised `uffs-broker --install (one-time; removes UAC prompts)`. But the broker is a Windows-only component (it vends elevated NTFS volume handles), and there is no UAC off Windows — so the hint was misleading and `uffs-broker --install` there only prints "Windows-only component". Print "not applicable (Windows-only component)" off Windows instead, matching the doctor's existing "Broker check skipped (non-Windows)". Windows behavior is unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
On macOS/Linux,
uffs --statusshowed:But the Access Broker is Windows-only (it vends elevated NTFS volume handles), and there is no UAC off Windows — so the "not installed / install for no UAC" hint is misleading, and
uffs-broker --installthere only prints "Windows-only component". Thedoctoralready handled this ("Broker check skipped (non-Windows)");--statusdidn't.Fix
Off Windows, the broker section now prints "not applicable (Windows-only component)" and returns. Windows behavior is unchanged.
Verification
macOS +
x86_64-pc-windows-msvcclippy clean; builds on both.🤖 Generated with Claude Code