Correctly handle currencies other than 2-decimal#14
Open
molbrown wants to merge 1 commit intosmeevil:masterfrom
Open
Correctly handle currencies other than 2-decimal#14molbrown wants to merge 1 commit intosmeevil:masterfrom
molbrown wants to merge 1 commit intosmeevil:masterfrom
Conversation
Author
A bug was exposed in use of currency_formatter when formatting 3-decimal currencies. Changes methods to use the subunit_to_unit value of the currency instead of assuming 2 decimal places.
molbrown
force-pushed
the
non-100_decimal_currencies
branch
2 times, most recently
from
05f8c05 to
b31e494
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was exposed in use of currency_formatter when formatting 3-decimal
currencies. Changes methods to use the subunit_to_unit value of the
currency instead of assuming 2 decimal places.