Added support for Phoenix LiveView#20
Open
okuyamacode wants to merge 2 commits intosmeevil:masterfrom
okuyamacode:master
Open
Added support for Phoenix LiveView#20okuyamacode wants to merge 2 commits intosmeevil:masterfrom okuyamacode:master
okuyamacode wants to merge 2 commits intosmeevil:masterfrom
okuyamacode:master
Conversation
To get set_locale working with Phoenix LiveView, we need to put the locale into the session
Contributor
|
@raerkeer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get set_locale working with Phoenix LiveView, the locale needs to be set to the session (as it's running in another thread and Gettext is threadlocal).
Please consider if you like this addition :)