refactor: consolidate smithy-client http binding and utility helpers (2/3) - #360
Closed
jterapin wants to merge 2 commits into
Closed
refactor: consolidate smithy-client http binding and utility helpers (2/3)#360jterapin wants to merge 2 commits into
jterapin wants to merge 2 commits into
Conversation
Consolidates the JSON, XML, and CBOR serde optimizations plus the smithy-schema extension helpers they share. - Cache list/map member and wire-name lookups on hot paths - Reuse Builder and Parser instances within codecs - Avoid coercion and helper indirection in union/structure handling - Align JSON and CBOR parser lookups with schema metadata - Honor protocol default timestamp behavior across serde - Lazily buffer XML parser text chunks; cache flattened trait lookups - Move sparse? and related helpers from ExtensionHelpers into Extension - Focus serde specs on behavior
Moves protocol-neutral HTTP binding and lookup logic out of individual plugins into shared Smithy::Client helpers, and prunes redundant schema attributes from the generator now that the runtime derives them from traits. - Add Smithy::Client::HttpBinding for shared request/response indexing - Consolidate helpers into Smithy::Client::Util (endpoint, encoding) - Centralize schema-driven lookups used by default params, param validation, host prefix, request compression, transfer encoding, and rpc_v2_cbor - Drop generator-side http_payload assignments; runtime resolves them
This was referenced Sep 3, 2026
Contributor
Author
|
Closing this superseded draft; the work is consolidated into PR #359. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of 3 splitting #358. Stacked on top of #359.
Summary
Moves protocol-neutral HTTP binding and lookup logic out of individual plugins into shared Smithy::Client helpers, and prunes redundant schema attributes from the generator now that the runtime derives them from traits.
Changes
Smithy::Client::HttpBindingfor shared request/response indexingSmithy::Client::Util(endpoint, encoding)default_params,param_validator,host_prefix,request_compression,transfer_encoding, andrpc_v2_cborhttp_payloadassignments; runtime resolves themStack
Validation
bundle exec rspecper gem: smithy-schema (161), smithy-json (78), smithy-xml (67), smithy-cbor (265), smithy-client (897, 2 pending). All pass.