Merged
Conversation
Goradii
force-pushed
the
support-mapped-as-dataclass
branch
from
403f3c6 to
cc97280
Compare
Member
|
@Goradii can you check if latest version of sqladmin still have this problem? If yes, let me know |
Contributor
Author
|
Yes same issue 😞 py313 |
2 tasks
mmzeynalli
requested changes
Apr 8, 2026
Comment on lines
+192
to
+203
| def _prepare_insert_dataclass(self, data: dict[str, Any]) -> dict[str, Any]: | ||
| try: | ||
| init = { | ||
| k: v | ||
| for k, v in data.items() | ||
| if self.model_view.model.__dataclass_fields__[k].init # type: ignore[attr-defined] # caught in except block | ||
| } | ||
| except AttributeError: | ||
| return {} | ||
| else: | ||
| return init | ||
|
|
Member
There was a problem hiding this comment.
You can easily check with dataclasses.is_dataclass
Comment on lines
205
to
206
| obj = self.model_view.model(**self._prepare_insert_dataclass(data)) | ||
|
|
Member
There was a problem hiding this comment.
Instead update here and in _insert_async:
if dataclasses.is_dataclass(self.model_view.model):
init_fields = {f.name for f in dataclasses.fields(self.model_view.model) if f.init}
obj = self.model_view.model(**{k: v for k, v in data.items() if k in init_fields})
else:
obj = self.model_view.model()
mmzeynalli
added
the
waiting-for-feedback
mmzeynalli
added
the
stale
mmzeynalli
added
ready-to-merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed insertion error if MappedAsDataclass #737
BEFORE FIX 3.8
AFTER FIX 3.8