Skip to content

Add regression tests for already-fixed issues #251 and #277 - #411

Merged
jemacineiras merged 2 commits into
sngular:mainfrom
joseegman:test/regression-openapi-asyncapi
Aug 16, 2026
Merged

Add regression tests for already-fixed issues #251 and #277#411
jemacineiras merged 2 commits into
sngular:mainfrom
joseegman:test/regression-openapi-asyncapi

Conversation

@joseegman

@joseegman joseegman commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Adds regression tests that confirm two previously-reported issues are already resolved on current main (they were fixed indirectly by later refactors; reported against much older versions).

Closes #251
Closes #277

#251 — [OpenApi] API code not generated when a $ref path parameter has no description (reported on 4.8.5)

New end-to-end fixture testNoDescriptionRefParameterGeneration uses the exact spec from the issue (/test/{testId} with a $ref to #/components/parameters/testId, no description, response $ref to #/components/responses/TestResponse). It asserts the API file is generated with the @PathVariable parameter.

#277 — [AsyncAPI] custom validators only generated in one model package when consumer/supplier use different modelPackage

New fixture testCustomValidatorsDifferentPackages configures the consumer and supplier with different modelPackages, both referencing the same schema (data) that has constraints (required, min/max, pattern, size). It asserts the customvalidator folder is generated with the full set of annotation + validator classes in both the consumer and producer packages, and that each DataDTO imports them from its own package.

Validation

  • multiapi-engine: full suite green — 133 tests, 0 failures (was 131 before these two cases).
  • Version bumped to 6.7.2 in all three modules (engine, Maven plugin, Gradle plugin).

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 4 duplication

Metric Results
Complexity 0
Duplication 4

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@jemacineiras jemacineiras added the release Adding this tag to a PR will cause a release on merge label Aug 16, 2026
jemacineiras
jemacineiras previously approved these changes Aug 16, 2026
@jemacineiras
jemacineiras merged commit 8ac4aff into sngular:main Aug 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Adding this tag to a PR will cause a release on merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with customvalidators generation [OpenApi] The api code is not generated without description

2 participants