fix: if the cli download field is empty, use the falback url

[andrewrobinsonhodges-snyk]

Description

Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.

Checklist

• Tests added and all succeed
• Regenerated mocks, etc. (make generate)
• Linted (make lint-fix)
• README.md updated, if user-facing
• License file updated, if new 3rd-party dependency is introduced

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Brittle Logic 🟡 [minor] The collectData function uses the placeholder attribute of the cliBaseDownloadURL input as a functional fallback. Using UI/UX elements for application logic is brittle: if the placeholder is later updated to a descriptive string (e.g., 'https://your-mirror.com'), the form will persist that invalid string as a configuration setting. Furthermore, this prevents users from unsetting the URL to rely on dynamic backend defaults, as the current placeholder string will be explicitly saved in their configuration, potentially leading to stale settings if the official download URL changes in the future. cliBaseDownloadURL: get('cliBaseDownloadURL').value || get('cliBaseDownloadURL').placeholder,

📚 Repository Context Analyzed This review considered 6 relevant code sections from 2 files (average relevance: 0.45) shared_ide_resources/ui/html/settings-fallback.html (4 segments, lines 201-300) infrastructure/configuration/template/config.html (2 segments, lines 201-300)