Skip to content

Fix unit result variable mappings - #157

Open
zakazaka95 wants to merge 1 commit into
software-mansion:mainfrom
zakazaka95:fix/issue-128-unit-mappings
Open

Fix unit result variable mappings#157
zakazaka95 wants to merge 1 commit into
software-mansion:mainfrom
zakazaka95:fix/issue-128-unit-mappings

Conversation

@zakazaka95

Copy link
Copy Markdown

Summary

  • discard zero-sized produced results before Cairo variable mappings are deduplicated
  • keep the data-carrying result of x += value from being overwritten by its unit return value
  • remove the downstream display workaround and add a focused regression test

Closes #128.

Validation

  • cargo test
  • cargo test --release
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --all-features --no-deps
  • formatting and git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix unit types mappings

1 participant