Add missing resource variants that close a user-provided client - #2978
Merged
adamw merged 3 commits intoSep 25, 2026
Merged
Conversation
…ultClient The usingClient and usingDefaultClient factory methods on Armeria and OkHttp backends hardcoded closeFactory/closeClient to false, giving users no way to have the backend close a user-provided client. This adds an optional closeFactory/closeClient: Boolean = false parameter to all public factory methods, allowing users to control whether the backend should close the underlying client on backend.close(). Armeria backends (9 files): - ArmeriaCatsBackend (CE3 + CE2) - ArmeriaFutureBackend - ArmeriaFs2Backend (CE3 + CE2) - ArmeriaZioBackend (ZIO 2 + ZIO 1) - ArmeriaMonixBackend - ArmeriaScalazBackend OkHttp backends (2 files): - OkHttpSyncBackend - OkHttpFutureBackend Closes softwaremill#2628
Member
|
Thanks - although compilation fails in a number of cases |
Reverts the closeFactory/closeClient parameters. A client passed to usingClient is never closed, as in all other backends. To let the backend close a user-provided client, use the resource variant: - ArmeriaMonixBackend: add resource and resourceUsingClient - ArmeriaZioBackend (zio1): add managedUsingClient - OkHttpMonixBackend: add resourceUsingClient - HttpClientZioBackend (zio, zio1): layerUsingClient now closes the client, like scopedUsingClient; zio1 gets managedUsingClient
adamw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client passed to
usingClientis never closed, same as in all other backends. To let the backend close a user-provided client, useresourceUsingClient/scopedUsingClient/managedUsingClient. This adds these variants where they were missing:ArmeriaMonixBackend:resource,resourceUsingClientArmeriaZioBackend(zio1):managedUsingClientOkHttpMonixBackend:resourceUsingClientHttpClientZioBackend(zio1):managedUsingClientBehavior change:
HttpClientZioBackend.layerUsingClient(zio, zio1) now closes the client when the layer is released, likescopedUsingClient. In zio1 it never closed the client before, becauseZManaged.makeEffectdidn't run the release effect.Closes #2628