feat: add SVG assets for toast notifications and update toast configu… - #457
Open
HoshinoIzumi wants to merge 3 commits into
Open
feat: add SVG assets for toast notifications and update toast configu…#457HoshinoIzumi wants to merge 3 commits into
HoshinoIzumi wants to merge 3 commits into
Conversation
Test Results98 tests 98 ✅ 9s ⏱️ Results for commit 5e0d697. ♻️ This comment has been updated with latest results. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ration
Summary
toast-config.tsx), using the newly exported mascot icons (toast1/toast2/toast3.svg) for the error, success, and warning toast types.assets.tsasSVGIMAGES.toastFail/toastSuccess/toastWarning, following the existing asset-import convention.Toast.show({ type, text1 })call sites unchanged — this only updates how the toast renders, not how it's triggered.#ECF6E3/#9CD710) to match the new success icon's palette.Release note
Status: