feat: 홈 대학교 경희대 추가 - #572
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wibaek
approved these changes
Jun 23, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91064130ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/university-web/src/constants/university.ts`:
- Line 110: The removal of university slugs from the HOME_UNIVERSITY_SLUGS array
will cause existing URLs for those removed slugs to result in 404 errors since
dynamicParams is set to false. To maintain user experience and SEO, add redirect
rules in next.config.js (or the Next.js configuration file) that map the old
slug-based URLs (for the universities that were removed) to either appropriate
new locations or a fallback page. This will preserve the user experience for
existing links and search engine rankings by using proper HTTP redirects instead
of letting them become broken links.
In `@apps/web/next.config.mjs`:
- Line 24: The universitySlugPattern in next.config.mjs has been narrowed to
only include inha and kyunghee, removing incheon and sungshin. This breaks
backward compatibility for existing URLs using those slugs. Add a redirects()
function export to next.config.mjs that handles the removed slug patterns by
redirecting old incheon and sungshin URLs to the inha destination, using
temporary redirects (permanent: false) to maintain future flexibility. The
redirects should cover both the list paths (like /university/list/incheon) and
dynamic paths (like /university/incheon/:path*) for those removed slugs.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: b5754969-9317-4866-818b-184d3ee18fe7
⛔ Files ignored due to path filters (2)
apps/university-web/public/images/univs/kyunghee.pngis excluded by!**/*.pngapps/web/public/images/univs/kyunghee.pngis excluded by!**/*.png
📒 Files selected for processing (5)
apps/university-web/src/constants/university.tsapps/university-web/src/types/university.tsapps/web/next.config.mjsapps/web/src/constants/university.tsapps/web/src/types/university.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용
홈에 경희대학교를 추가했습니다