Skip to content

fix: 학교 인증 후 지원하기 복귀 처리 - #586

Merged
yoonc01 merged 1 commit into
mainfrom
fix/apply-school-verification-redirect
Jun 26, 2026
Merged

fix: 학교 인증 후 지원하기 복귀 처리#586
yoonc01 merged 1 commit into
mainfrom
fix/apply-school-verification-redirect

Conversation

@yoonc01

@yoonc01 yoonc01 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

관련 이슈

학교 미인증자 지원 시 학교 인증으로 redirect

작업 내용

  • 지원하기 페이지 진입 시 로그인된 사용자에게 학교 정보(homeUniversityId)가 없으면 학교 인증 페이지로 이동하도록 처리했습니다.
  • 학교 인증 페이지에 returnTo=applicationApply 의도 기반 파라미터를 추가해, 인증 완료 후 지원하기 페이지로 복귀할 수 있도록 했습니다.
  • useSearchParams 사용에 맞춰 학교 인증 페이지 콘텐츠를 Suspense로 감쌌습니다.

@yoonc01 yoonc01 self-assigned this Jun 26, 2026
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jun 26, 2026 2:57pm
solid-connection-web Ready Ready Preview, Comment Jun 26, 2026 2:57pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jun 26, 2026 2:57pm

@github-actions github-actions Bot added the web label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

  1. 지원 경로 분기
    • ApplyPageContent가 인증 초기화 여부, 로그인 상태, homeUniversityId를 확인해 조건이 맞으면 /my/school-email?returnTo=applicationApply로 이동하고, 해당 조건에서는 렌더를 중단합니다.
  2. 완료 복귀 분기
    • 학교 이메일 인증 화면이 SuspenseCloudSpinnerPage로 감싸졌고, 완료 버튼이 returnTo=applicationApply에 따라 /university/application/apply 또는 /로 이동합니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • wibaek
  • enunsnv
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 제목이 학교 인증 후 지원하기 복귀 처리라는 핵심 변경을 간결하게 잘 요약합니다.
Description check ✅ Passed 관련 이슈와 작업 내용이 포함되어 있고 PR 목적도 대체로 맞지만, 이슈 번호와 특이 사항 섹션은 비어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/apply-school-verification-redirect

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc3f3a5c40

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/src/app/university/application/apply/ApplyPageContent.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/web/src/app/university/application/apply/ApplyPageContent.tsx`:
- Around line 51-58: The redirect logic in ApplyPageContent is using only the
token-derived homeUniversityId, while confirmation success is tracked from
backend state, which can cause a loop after school email verification. Update
the flow by syncing auth state in usePostConfirmSchoolEmail’s onSuccess (for
example by refreshing the token or calling useAuthStore’s
setAccessToken/setHomeUniversityId) so homeUniversityId reflects the verified
state, or adjust the ApplyPageContent useEffect guard to also consider
myInfo.homeUniversityName before redirecting. Keep the redirect decision
consistent across ApplyPageContent and usePostConfirmSchoolEmail.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 4a413029-638c-4032-9ac0-e527b7eb479f

📥 Commits

Reviewing files that changed from the base of the PR and between bb54f63 and cc3f3a5.

📒 Files selected for processing (3)
  • apps/web/src/app/my/school-email/_ui/SchoolEmailVerificationContent/index.tsx
  • apps/web/src/app/my/school-email/page.tsx
  • apps/web/src/app/university/application/apply/ApplyPageContent.tsx

Comment thread apps/web/src/app/university/application/apply/ApplyPageContent.tsx
@yoonc01
yoonc01 merged commit 535ac63 into main Jun 26, 2026
13 checks passed
@yoonc01
yoonc01 deleted the fix/apply-school-verification-redirect branch June 26, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant