fix: 학교 인증 후 지원하기 복귀 처리 - #586
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Walkthrough
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc3f3a5c40
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/app/university/application/apply/ApplyPageContent.tsx`:
- Around line 51-58: The redirect logic in ApplyPageContent is using only the
token-derived homeUniversityId, while confirmation success is tracked from
backend state, which can cause a loop after school email verification. Update
the flow by syncing auth state in usePostConfirmSchoolEmail’s onSuccess (for
example by refreshing the token or calling useAuthStore’s
setAccessToken/setHomeUniversityId) so homeUniversityId reflects the verified
state, or adjust the ApplyPageContent useEffect guard to also consider
myInfo.homeUniversityName before redirecting. Keep the redirect decision
consistent across ApplyPageContent and usePostConfirmSchoolEmail.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 4a413029-638c-4032-9ac0-e527b7eb479f
📒 Files selected for processing (3)
apps/web/src/app/my/school-email/_ui/SchoolEmailVerificationContent/index.tsxapps/web/src/app/my/school-email/page.tsxapps/web/src/app/university/application/apply/ApplyPageContent.tsx
관련 이슈
학교 미인증자 지원 시 학교 인증으로 redirect
작업 내용
homeUniversityId)가 없으면 학교 인증 페이지로 이동하도록 처리했습니다.returnTo=applicationApply의도 기반 파라미터를 추가해, 인증 완료 후 지원하기 페이지로 복귀할 수 있도록 했습니다.useSearchParams사용에 맞춰 학교 인증 페이지 콘텐츠를Suspense로 감쌌습니다.