Skip to content

89 tune copy function #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PreciousOritsedere merged 4 commits into from
Sep 11, 2026
+19 −19
Merged

89 tune copy function #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c92470
rename copy dropdown
PreciousOritsedere Sep 11, 2026
60a7ebf
Hide Make a copy on folders in the context menu
PreciousOritsedere Sep 11, 2026
88bba89
Hide Make a copy on folders in the item menu
PreciousOritsedere Sep 11, 2026
20ddc9b
Guard copy so folders cannot be copied
PreciousOritsedere Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/components/FileItemMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,12 @@ export default function FileItemMenu({
<Download />
Download
</DropdownMenuItem>
<DropdownMenuItem onClick={() => run(onCopy)}>
<Copy />
Copy
</DropdownMenuItem>
{file.type === "file" && (
<DropdownMenuItem onClick={() => run(onCopy)}>
<Copy />
Make a Copy
</DropdownMenuItem>
)}
<DropdownMenuItem onClick={() => run(onShare)}>
<Share2 />
Share
Expand Down
19 changes: 11 additions & 8 deletions app/components/file-manager/FileManagerContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,14 +331,6 @@ export default function FileManagerContent() {
dispatchFileAction({ type: "download", file });
},
},
{
label: "Copy",
icon: Copy,
onClick: () => {
closeContextMenu();
dispatchFileAction({ type: "copy", file });
},
},
{
label: "Share",
icon: Share2,
Expand All @@ -360,6 +352,17 @@ export default function FileManagerContent() {
});
}

if (file.type === "file") {
actions.push({
label: "Make a Copy",
icon: Copy,
onClick: () => {
closeContextMenu();
dispatchFileAction({ type: "copy", file });
},
});
}

actions.push({
label: "Delete",
icon: Trash2,
Expand Down
9 changes: 2 additions & 7 deletions app/components/file-manager/hooks/useFileOperations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import type { AccessLevel } from "../../ShareDialog";
import {
getAuthenticatedSession,
copyFileResource,
copyFolderResource,
downloadFile,
downloadFolderAsZip,
deleteFileResource,
Expand Down Expand Up @@ -91,19 +90,15 @@ export function useFileOperations({

const copyFile = useCallback(
async (file: FileItemData) => {
if (!file) {
if (!file || file.type === "folder") {
return;
}

const result = await runWithToast(
`Copying "${file.name}"...`,
async () => {
const { fetch: fetchFn } = getAuthenticatedSession();
if (file.type === "folder") {
await copyFolderResource(file, fetchFn);
} else {
await copyFileResource(file, fetchFn);
}
await copyFileResource(file, fetchFn);
},
{
successMessage: `Copied "${file.name}"`,
Expand Down
Loading