fix(ci): pass per-app SENTRY_DSN secrets to the staging secret renderer - #5
Merged
Merged
Conversation
The "Render and apply staging secrets" step never passed any SENTRY_DSN env to render-staging-secrets.py, so SENTRY_DSN was always rendered empty in the runtime Secrets (the Phase 18 wiring was incomplete). Pass the three per-app secrets SENTRY_DSN_SERVER_2 / _REPLAYS_FETCHER / _REPLAY_PARSER_2 so each app's runtime Secret carries its DSN. Completes the per-app wiring from the prior renderer change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deploy-staging
Render and apply staging secretsstep never passed any SENTRY_DSN env to the renderer, so SENTRY_DSN was rendered empty in all runtime Secrets (verified: cluster secrets have no SENTRY_DSN). The Phase 18 wiring was incomplete. This passes the three per-app secrets so each app's runtime Secret carries its DSN. Completes #4.🤖 Generated with Claude Code