Configure @/ path aliases in tsconfig and stop tracking tsconfig.tsbuildinfo - #1462
Merged
hman38705 merged 1 commit intoSep 1, 2026
Conversation
…ildinfo Closes solutions-plug#1303, solutions-plug#1304 - The frontend/ Next.js App Router scaffold (solutions-plug#1303) was already in place (strict TS, private, engines, App Router) except that tsconfig.tsbuildinfo was committed to git and not covered by .gitignore -- untracked it and added a **/tsconfig.tsbuildinfo entry. - solutions-plug#1304: tsconfig.json had no path aliases even though jest.config.js already mapped @/* -> src/$1, so tsc/next build resolved @/ imports differently than Jest. Added baseUrl + paths (@/*, @/components/*, @/lib/*, @/styles/*) to tsconfig.json so all three toolchains agree. - Converted the 14 files still using 3-4 level relative imports (../../../lib/..., ../../../../components/...) to the new @/lib/... and @/components/... aliases, per the acceptance criteria that no deeper-than-two-level relative import remain in the scaffold.
|
@jasmine874 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(strict TypeScript,"private": true,enginesconstraint, App Router undersrc/app) -- the one gap wastsconfig.tsbuildinfobeing committed to git and not covered by.gitignore. Untracked it and added a**/tsconfig.tsbuildinfoentry.tsconfig.jsonhad nopathsconfigured even thoughjest.config.jsalready mapped@/* -> src/$1-- meaningtsc/next buildresolved@/imports differently than Jest did. AddedbaseUrl+paths(@/*,@/components/*,@/lib/*,@/styles/*) totsconfig.jsonso all three toolchains (Next.js compiler, Jest, tsc) agree.../../../lib/...,../../../../components/...) to the new@/lib/.../@/components/...aliases, satisfying the acceptance criteria that no import deeper than two relative levels remain in the scaffold.Closes #1303
Closes #1304
Test plan
npm install && npm run build(frontend/) succeeds with the new aliasesnpx tsc --noEmitresolves@/...imports with no errorsnpm test(Jest) still passes with the same aliases