go.mod: bump go directive to 1.25.9 - #192
Merged
Merged
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
upgrade/go-1.25.9-cve
branch
from
September 5, 2026 05:33
fba4a81 to
c051fff
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
upgrade/go-1.25.9-cve
branch
from
September 5, 2026 05:42
c051fff to
3cd4b08
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
xq9mend
force-pushed
the
upgrade/go-1.25.9-cve
branch
from
September 5, 2026 05:49
3cd4b08 to
66bb1fb
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks! ---Powered by SONiC BuildBot
|
Bump go directive from 1.15 to 1.25.9 in go-server-server/go.mod and swsscommon/go.mod. Replace apt-installed golang-go (Go 1.19) in Dockerfile.build with Go 1.25.9 downloaded from go.dev. Go 1.19 cannot parse MAJOR.MINOR.PATCH go.mod format required by Go 1.21+. Note: trixie-backports golang-go (1.26) cannot be used because the CDN swsscommon debs link against SONiC-patched libnl versioned symbols (@libnl_3) which are absent from native trixie libnl. Tested: dpkg-buildpackage passes on bookworm with Go 1.25.9 tarball. Signed-off-by: xq9mend <xq9mend@users.noreply.github.com>
xq9mend
force-pushed
the
upgrade/go-1.25.9-cve
branch
from
September 5, 2026 07:05
66bb1fb to
b24f565
Compare
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
|
Are there required security fixes in Go 1.25.9 that are not in 1.24.4? restapi is based on Debian Trixie and the default Go version on Debian Trixie is 1.24. |
Contributor
Author
|
The sonic-slave-trixie was upgraded from 1.24 to 1.26 in commit a793a0d94 (#28894, merged Aug 14). So trixie's default 1.24 is no longer the slave baseline. Go 1.25.9 is consistent with the 1.25.9 used in the same CVE batch across sonic-mgmt-common, sonic-mgmt-framework, and sonic-alpine. |
mramezani95
self-requested a review
September 10, 2026 00:49
mramezani95
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Bump go directive from 1.15 to 1.25.9 to pick up Go stdlib security fixes.
Work item tracking
How I did it
Update
godirective ingo-server-server/go.modandswsscommon/go.modfrom1.15to1.25.9.How to verify it
Build go-server-server and confirm no build errors.