fix: set Helm deploy type for application services - #929
Open
eseliger wants to merge 1 commit into
Open
Conversation
eseliger
force-pushed
the
fix/consistent-deploy-type
branch
from
August 26, 2026 13:41
80125e0 to
3118c24
Compare
Frontend explicitly identifies itself as a Helm deployment, while other Sourcegraph application containers rely on defaults or omit the deployment type entirely. Set DEPLOY_TYPE=helm consistently across Sourcegraph application containers and cover every rendered workload, including split Worker deployments. Amp-Thread-ID: https://ampcode.com/threads/T-01a03b58-f45a-72a4-996d-962f25f3c9ab
eseliger
force-pushed
the
fix/consistent-deploy-type
branch
from
August 26, 2026 13:43
3118c24 to
7bae6a5
Compare
eseliger
changed the title
eseliger
marked this pull request as ready for review
August 26, 2026 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
DEPLOY_TYPE=helmconsistently for every Sourcegraph application container rendered by the chart: Blobstore, Frontend, Migrator, Gitserver, both indexed-search containers, Searcher, precise and syntactic code-intel workers, Syntect, and all Worker deployments.Third-party infrastructure containers such as PostgreSQL, Redis, Prometheus, Grafana, Jaeger, and OpenTelemetry are intentionally excluded because this Sourcegraph-specific variable has no meaning for them.
This env var tells our services to be in Kubernetes mode. Right now, not setting it defaults to kubernetes, so in practice this change will not change behavior. But it seems way safer to set this explicitly instead of relying on the env vars default.