Skip to content

Allow inactive themes to update from Themes & Extensions - #2946

Open
RabbiIslamRony wants to merge 1 commit into
sovware:developmentfrom
RabbiIslamRony:fix/690-inactive-theme-updates
Open

Allow inactive themes to update from Themes & Extensions#2946
RabbiIslamRony wants to merge 1 commit into
sovware:developmentfrom
RabbiIslamRony:fix/690-inactive-theme-updates

Conversation

@RabbiIslamRony

Copy link
Copy Markdown
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Security fix
  • Improvement
  • New Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Text changes
  • Other... Please describe:

Description

How to reproduce the issue or how to test the changes

  1. Install a Directorist theme included in the authenticated subscription, keep another theme active, and make an update available for the inactive Directorist theme.
  2. Go to Directorist > Themes & Extensions, open the Themes tab, and locate the installed inactive theme under Available in your subscription.
  3. Confirm that Activate, Live Preview, and Update are all available. The Update action must target that inactive theme's stylesheet and use the existing theme-update request.
  4. Confirm that an installed theme without an update does not show Update, an uninstalled theme still shows Install, and the active-theme behavior is unchanged.

Verification completed:

  • LocalWP UI reproduction with inactive dJobs: Activate, Live Preview, and Update were present, with data-target="djobs".
  • PHP syntax check passed for the changed template.
  • Targeted composer phpcs passed under PHP 8.2.
  • Render-state matrix passed for inactive/updatable, inactive/current, and uninstalled themes.
  • git diff --check passed.

Any linked issues

Fixes #690

Checklist

@RabbiIslamRony

Copy link
Copy Markdown
Member Author

The PHPCS job stopped before code checkout because the current development-branch workflow still uses pull_request_target and actions/checkout now refuses to check out fork code in that privileged context. No project code or PHPCS command ran. This infrastructure failure is addressed by the focused security PR #2945; the check should be rerun after #2945 merges. The changed PHP template passes the same repository PHPCS rules locally under PHP 8.2.

@Armanul46 Armanul46 added this to the v8.9.3 milestone Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants