Various bug fixes - #197
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR applies small fixes to the Argos collection pipeline, including checkpoint-chain integrity, container sizing bookkeeping, and a macOS-specific heartbeat override to avoid a known alignment issue.
Changes:
- Update
CollectableCheckpoint::detachPrev()to also clear the previous node’snext_link before resettingprev_. - On macOS, force Argos collector heartbeat values > 1 down to 1 with a diagnostic message.
- Fix container max-size tracking by computing container size before moving the payload into the checkpointer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/simdb/apps/argos/Checkpoint.hpp | Ensures checkpoint-chain links are fully detached (both directions) when trimming history. |
| include/simdb/apps/argos/ArgosCollector.hpp | Adds macOS heartbeat override and fixes ordering so container size is computed before std::move into checkpoints. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
colbynyce-mips
force-pushed
the
colby-nyce/argos
branch
from
August 13, 2026 22:14
1718f25 to
8d46f8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.