Resolve PR #36 review feedback: untrack dist/ and sync with upstream main

[rlweb]

What

Addresses the two requests from maintainer @panda-sandeep on bug0inc/passmark#36 (the "Pluggable cache with redis as fallback" PR, whose head is sparklayer-io:cache-plugin):

1. "Could you uncommit the dist/ directory?" — dist/ was force-committed despite being listed in .gitignore. This branch removes it from tracking (git rm -r --cached dist); it stays ignored.
2. "If you can resolve the merge conflict, that would be great!" — cache-plugin had diverged significantly from bug0inc/passmark:main. This branch merges current upstream main and resolves all conflicts.

How the merge conflicts were resolved

Upstream had meanwhile refactored src/redis.ts from a module-level singleton into a lazy, config-aware getRedis() (honouring configure({ redis: { url } }) then REDIS_URL). The cache-plugin feature had instead replaced redis.ts with an eagerly-constructed pluggable cache store.

Rather than pick one design, the resolution keeps upstream's richer redis.ts and reworks src/cache.ts into a pluggable layer that wraps it:

• getCache() is now lazy + memoized (mirrors getRedis()), so configure() still works before first use.
• CACHE_PROVIDER selects the backend: redis (default), file (JSON on disk at CACHE_DIR, handy for committing a warm cache to Git for CI — the original use case), or none.
• The redis backend delegates to getRedis(), so the upstream configure({ redis }) API and REDIS_URL fallback are preserved.
• data-cache.ts and index.ts now call getCache(); tests mock ../cache's getCache.

Also fixed a duplicate createOpenAI import in src/models.ts introduced by the auto-merge, and documented CACHE_PROVIDER/CACHE_DIR in .env.example and the README.

Verification

• pnpm run build (tsc) — passes
• pnpm test — 164 passed
• pnpm run lint — 0 errors (pre-existing any warnings only)

Note on branches

This PR targets cache-plugin so the diff shows exactly the dist removal + upstream sync. To actually update bug0inc#36, these commits need to land on the cache-plugin branch (e.g. merge this PR, or I can push directly to cache-plugin if you'd prefer — just say the word).

https://claude.ai/code/session_01WvniLbWm19ZpfXxKRyW6Kv

---

Generated by Claude Code

[gemini-code-assist]

Code Review

This pull request introduces CUA (Computer-Use Agent) mode for visual, coordinate-based browser automation via OpenAI's Responses API, video-based assertions evaluated via Gemini's Files API, support for the OpenCode Zen gateway, and configurable consensus policies for assertion disagreements. It also refactors Redis and Cache initialization to be lazy. The review feedback highlights several critical issues: potential TypeError crashes due to unsafe property access on test?.info() in src/assertion.ts and missing null checks on action in src/cua/actions.ts; a compatibility issue with screencast in src/video.ts on non-Chromium browsers; and configuration-sync bugs in src/redis.ts and src/cache.ts where static initialization flags prevent re-configuration when configure() is called with new parameters.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Unsafe property access test?.info().annotations when test is undefined. If test is not provided, test?.info() will evaluate to undefined, and attempting to access .annotations on it will throw a TypeError. Use optional chaining to safely access the annotations array.

    test?.info()?.annotations.push({\n      type: \"AI Summary (video analysis)\",\n      description: videoResult.reasoning,\n    });

[gemini-code-assist]

Caching the initialized state prevents re-configuration of the Redis client when configure() is called with a new URL. Instead of a static initialized flag, track the active URL and re-initialize the client if the URL changes.

let client: Redis | null = null;\nlet activeUrl: string | undefined = undefined;\n\n/**\n * Returns a memoized Redis client. Reads `configure({ redis: { url } })` first,\n * then falls back to `process.env.REDIS_URL`. Returns null when neither is set,\n * which disables step caching, {{global.*}} placeholders, and project data.\n *\n * Lazy: the connection is opened on first call so users can call `configure()`\n * before any Redis-dependent code path runs.\n */\nexport function getRedis(): Redis | null {\n  const url = getConfig().redis?.url ?? process.env.REDIS_URL;\n  \n  if (url !== activeUrl) {\n    if (client) {\n      client.disconnect();\n      client = null;\n    }\n    activeUrl = url;\n    if (url) {\n      client = new Redis(url);\n    } else {\n      logger.warn(\n        \"Redis URL not set (configure({ redis: { url } }) or REDIS_URL). \" +\n          \"Step caching, global placeholders, and project data are disabled.\",\n      );\n    }\n  }\n  return client;\n}

[gemini-code-assist]

Caching the initialized state prevents re-configuration of the Cache store when configure() or env vars are updated. Track the active provider, directory, and redis client to dynamically re-initialize the cache store when configuration changes.

let cacheInstance: CacheStore | null = null;\nlet activeProvider: string | undefined = undefined;\nlet activeDir: string | undefined = undefined;\nlet activeRedis: any = undefined;\n\n/**\n * Returns a memoized cache store based on the `CACHE_PROVIDER` env var:\n *   - \"redis\" (also the default): uses Redis via `getRedis()`, which honors\n *     `configure({ redis: { url } })` and `REDIS_URL`.\n *   - \"file\": uses JSON files on disk at `CACHE_DIR` (defaults to\n *     `.passmark-cache`). Handy for committing a warm cache to Git for CI.\n *   - \"none\": disables caching entirely.\n *\n * Returns null when caching is disabled or no Redis URL is configured, which\n * disables step caching, {{global.*}} placeholders, and project data.\n *\n * Lazy: resolved on first call so users can call `configure()` beforehand.\n */\nexport function getCache(): CacheStore | null {\n  const provider = process.env.CACHE_PROVIDER?.toLowerCase();\n  const dir = process.env.CACHE_DIR || \".passmark-cache\";\n  const redis = getRedis();\n\n  if (\n    provider !== activeProvider ||\n    (provider === \"file\" && dir !== activeDir) ||\n    (provider !== \"none\" && provider !== \"file\" && redis !== activeRedis)\n  ) {\n    activeProvider = provider;\n    activeDir = dir;\n    activeRedis = redis;\n\n    if (provider === \"none\") {\n      logger.warn(\"CACHE_PROVIDER is 'none'. Caching is disabled.\");\n      cacheInstance = null;\n    } else if (provider === \"file\") {\n      logger.info(`Using file-based cache at: ${dir}`);\n      cacheInstance = new FileStore(dir);\n    } else if (provider && provider !== \"redis\") {\n      logger.warn(`Unknown CACHE_PROVIDER '${provider}'. Caching is disabled.`);\n      cacheInstance = null;\n    } else {\n      cacheInstance = redis ? new RedisStore(redis) : null;\n    }\n  }\n  return cacheInstance;\n}

[gemini-code-assist]

Missing null/undefined check on action in executeAction can cause a TypeError crash if an empty or null action is passed. Add a defensive guard at the beginning of the function.

export async function executeAction(page: Page, action: ComputerAction): Promise<void> {\n  if (!action) return;\n  switch (action.type) {

[gemini-code-assist]

Unsafe access to screencast on Playwright's Page object without checking if it is supported. screencast is an internal, undocumented Chromium-only API. If the tests are run on Firefox or WebKit, this will throw a TypeError. Add a check to verify screencast is supported before starting the recording.

    const pageInstance = resolvePage(this.page) as any;\n    if (!pageInstance.screencast) {\n      throw new Error(\"Screencast is not supported on this browser/platform (Chromium only)\");\n    }\n    await pageInstance.screencast.start({\n      path: this.filePath,\n      size: { width: VIDEO_DEFAULT_WIDTH, height: VIDEO_DEFAULT_HEIGHT },\n    });