Avoid DebugInfo warnings (take two)#2345
Merged
Merged
Conversation
Since now all calls were `_get_debug_info("config", ...)` we can remove
this argument again, reverting more of the initial PR and just adding
the config options in there.
tbennun
approved these changes
Apr 23, 2026
Collaborator
|
cscs-ci run |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In PR #2321 we introduced a way to turn of automatic stack inspection when adding a node to a state without explicitly stating debug info (such as file name, line info, ...). Since merging this PR, we get a ton of
DeprecationWarnings from code added in_get_debug_info().In a first attempt (see PR #2344), we tried to work around the issue by setting
._default_line_infoon the state. This method proved to be very verbose and unnecessarily complicates parsing, where we have a legitimate use-case for explicitly passing along an explicitDebugInfo.This PR suggests to keep the API of
state.add_*()functions as before, partially reverting changes from PR #2321. Doing so, we can drop the deprecation warnings because nothing changes.