feat: allow-list jailed VFIO devices - #1
Merged
Conversation
Extend the strict v1 manifest with an optional VFIO-only device list. Accept only the control node and canonical numeric IOMMU-group paths, require exact in-jail destinations, and reject duplicates, aliases, and mounts that overlap the reserved device tree. Resolve each selected host node as a real character device before the pivot, then recreate its major/minor identity inside the private jail. This avoids bind-mounting host /dev or changing host device ownership. CPU-only manifests remain compatible because the new list defaults empty. Document the boundary and dedicated hardware-runner coverage, and bump the binary package version to 0.1.10. Linux amd64 container tests pass with 13 unit tests, strict Clippy, and an optimized release build. Signed-off-by: Aaqa Ishtyaq <aaqaishtyaq@gmail.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/dev/vfio/vfioand canonical numeric IOMMU-group nodesdev/treeWhy
Machined now allocates complete IOMMU groups exclusively. Cloud Hypervisor needs those allocator-derived devices inside its dedicated jail without exposing the host device tree or changing Firecracker jailer behavior.
Validation
cargo fmt --checkcargo test --locked(13 Linux amd64 tests)