feat: model protocol-aware sandbox services - #8
Conversation
Expose raw_l4 ingress with explicit tcp or udp transport in the public SDK and document exposedPorts as a deprecated TCP compatibility shorthand. Signed-off-by: Aaqa Ishtyaq <aaqaishtyaq@gmail.com>
Expose runtime service metadata in the SDK so URL-based services and native UDP endpoints use distinct client representations. Add transport, host, and port fields without changing the raw_l4 creation contract. Signed-off-by: Aaqa Ishtyaq <aaqaishtyaq@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75f31ba8ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| templateId, | ||
| region: options?.region, | ||
| metadata: options?.metadata, | ||
| ...(ingressOptions.ingress ? { ingress: ingressOptions.ingress } : {}), |
There was a problem hiding this comment.
When a caller relies on config.defaultTemplateId and invokes sandbox.create() without options, options remains undefined because the type assertion does not create an object. Reading ingressOptions.ingress therefore throws before the API request, breaking the previously supported optionless creation path; initialize the derived value to an empty object or use optional chaining.
Useful? React with 👍 / 👎.
|
Closing as superseded by merged PR 11. The generic ingress and protocol-aware service changes are already included in main and the rewritten SDK. |
1 participant
Summary
sandbox.runtime.servicesValidation
npm run typechecknpm test -- --runDepends on Edge #68.